feat(place/visitor_mailer): provide a QR code for building access#516
Open
feat(place/visitor_mailer): provide a QR code for building access#516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created an interface so we can standardise providing guests QR codes that will get them through the base building gates
https://github.com/PlaceOS/driver/blob/master/src/placeos-driver/interface/guest_building_access.cr
This is implemented on our Integriti driver
https://github.com/PlaceOS/drivers/blob/master/drivers/inner_range/integriti.cr#L956-L1010
Somewhat based on how I saw @camreeves code working for Gallagher
Additions we could make to this pull request:
revoke_guest_accessCurrently the QR code being generated is just taking the card data and creating a HEX or Base64 version of that.
I asked ChatGPT about this so we probably need to confirm with the QR code readers that are in use, or maybe @w-le @camreeves can remember what was used when we last did this